Review Request: Replacing Repositories QComboBox by Filtered QListWidget in the Reviewboard Plugin

Milian Wolff mail at milianw.de
Sun Nov 20 17:22:58 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103187/#review8347
-----------------------------------------------------------

Ship it!


looks good, thanks. Please commit or provide the patch as created by "git format-patch". Thanks

- Milian Wolff


On Nov. 20, 2011, 5:07 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103187/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2011, 5:07 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Eases searching for a project when submitting a patch. Actually, not using a filtered QListWidget is underestimating the size and power of KDE ;)
> 
> 
> Diffs
> -----
> 
>   plugins/reviewboard/reviewpatch.ui 809769c 
>   plugins/reviewboard/reviewpatchdialog.cpp c0fb8d3 
> 
> Diff: http://git.reviewboard.kde.org/r/103187/diff/diff
> 
> 
> Testing
> -------
> 
> This patch was submitted with the modified UI.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111120/d7ac2665/attachment.html>


More information about the KDevelop-devel mailing list