Review Request: Move "Jump To File" functionality from the model of executescript-Plugin to the general OutputView model. (Thus enabling it for the execute and externalscript plugin's too.)

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103151/#review8252
-----------------------------------------------------------


The more interesting tests are to check all other users of OutputModel wether they break. I can see for example that grepview uses the OutputModel class and that one has some very specific needs. IMHO you should create a new class in the outputview library, something like a FileDetectingOutputModel (sorry I'm bad at names) and put the functionality into it. This would make the feature an opt-in and no existing plugins that use outputmodel would break. FileDetectingOutputModel could even just be a new subclass to avoid the code-duplication. Oh and you should check which of the other plugins in kdevplatform/kdevelop could make use of it.

- Andreas Pakulat


On Nov. 16, 2011, 7:54 p.m., Manuel Riecke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103151/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2011, 7:54 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Move the functionality to detect filename+line number from the output of a executed script/exectuable from ExecuteScriptOutputModel to OutputModel. This adds this functionality to all plugins showing the output of a executable, e.g. execute, executescript and externalscript.
> 
> 
> Diffs
> -----
> 
>   outputview/outputmodel.h b4c9631 
>   outputview/outputmodel.cpp 317e3ee 
>   plugins/executescript/CMakeLists.txt 5d6168f 
>   plugins/executescript/executescriptoutputmodel.h 180adbd 
>   plugins/executescript/executescriptoutputmodel.cpp 1c852e9 
>   plugins/executescript/scriptappjob.cpp 3b68ca5 
> 
> Diff: http://git.reviewboard.kde.org/r/103151/diff/diff
> 
> 
> Testing
> -------
> 
> It still compiles, all the three plugins (execute, executescript and externalscript) work and have the "Jump to file" functionality.
> 
> 
> Thanks,
> 
> Manuel Riecke
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111117/b2e581fa/attachment.html>