Review Request: Move "Jump To File" functionality from the model of executescript-Plugin to the general OutputView model. (Thus enabling it for the execute and externalscript plugin's too.)

Manuel Riecke spell1337 at gmail.com
Wed Nov 16 03:16:45 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103151/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

Move the functionality to detect filename+line number from the output of a executed script/exectuable from ExecuteScriptOutputModel to OutputModel. This adds this functionality to all plugins showing the output of a executable, e.g. execute, executescript and externalscript.


Diffs
-----

  outputview/outputmodel.h b4c9631 
  outputview/outputmodel.h b4c9631 
  outputview/outputmodel.cpp 317e3ee 
  outputview/outputmodel.cpp 317e3ee 
  plugins/executescript/CMakeLists.txt 5d6168f 
  plugins/executescript/CMakeLists.txt 5d6168f 
  plugins/executescript/executescriptoutputmodel.h 180adbd 
  plugins/executescript/executescriptoutputmodel.h 180adbd 
  plugins/executescript/executescriptoutputmodel.cpp 1c852e9 
  plugins/executescript/executescriptoutputmodel.cpp 1c852e9 
  plugins/executescript/scriptappjob.cpp 3b68ca5 
  plugins/executescript/scriptappjob.cpp 3b68ca5 

Diff: http://git.reviewboard.kde.org/r/103151/diff/diff


Testing
-------

It still compiles, all the three plugins (execute, executescript and externalscript) work and have the "Jump to file" functionality.


Thanks,

Manuel Riecke

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111116/6422a71e/attachment.html>


More information about the KDevelop-devel mailing list