Review Request: Enhance QtHelp context menu

[Valentyn Pavliuchenko]

> On Nov. 10, 2011, 2:55 p.m., Milian Wolff wrote:
> > documentation/qthelp/qthelpdocumentation.cpp, line 207
> > <http://git.reviewboard.kde.org/r/103102/diff/2/?file=40761#file40761line207>
> >
> >     as a further improvement (second patch?), please hide this if m_info.size() == 1.
> >     
> >     if you look at your screenshot, that action is pretty useless in such a case.

First version of this patch was including that, but I've removed that. I've thought that it's like hiding a feature, because m_info.size() == 1 almost every time, so the user will never know about it and will not try to search this in context menu when he needs. So IMHO it's better to show it all the time.


- Valentyn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103102/#review8101
-----------------------------------------------------------


On Nov. 9, 2011, 11:10 p.m., Valentyn Pavliuchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103102/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2011, 11:10 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> 1. Added "Copy" to context menu - allows copying code examples (CMake and Manpage docs already have it)
> 2. Use radiobuttons instead of key list - makes menu more understandable.
> 
> 
> Diffs
> -----
> 
>   documentation/qthelp/qthelpdocumentation.h bb6c202 
>   documentation/qthelp/qthelpdocumentation.cpp d2e0c19 
> 
> Diff: http://git.reviewboard.kde.org/r/103102/diff/diff
> 
> 
> Testing
> -------
> 
> Manual.
> 
> 
> Screenshots
> -----------
> 
> New context menu
>   http://git.reviewboard.kde.org/r/103102/s/334/
> 
> 
> Thanks,
> 
> Valentyn Pavliuchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111110/872b4441/attachment.html>