Review Request: Checking infrastructure for the KDevPlatform

[Aleix Pol Gonzalez]

> On Nov. 7, 2011, 11:23 p.m., Milian Wolff wrote:
> > language/checks/controlflownode.h, line 76
> > <http://git.reviewboard.kde.org/r/103071/diff/1/?file=40582#file40582line76>
> >
> >     public api, should get a dptr for maintainability, or?

I'm not sure, I don't like dptr for such objects where there should have many instances. Also I think it's unlikely to change.


> On Nov. 7, 2011, 11:23 p.m., Milian Wolff wrote:
> > language/checks/controlflownode.cpp, line 24
> > <http://git.reviewboard.kde.org/r/103071/diff/1/?file=40583#file40583line24>
> >
> >     why is m_nodeRange not initialized with invalid?

Yes, it made me spend quite some time debugging... properly it would make sense to fix it RangeInRevision, but I can't change it here yet.


> On Nov. 7, 2011, 11:23 p.m., Milian Wolff wrote:
> > language/checks/dataaccessrepository.h, line 71
> > <http://git.reviewboard.kde.org/r/103071/diff/1/?file=40584#file40584line71>
> >
> >     again: please d-ptr for maintainability - or?

Same as above


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103071/#review8010
-----------------------------------------------------------


On Nov. 8, 2011, 1:47 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103071/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2011, 1:47 a.m.)
> 
> 
> Review request for KDevelop, Milian Wolff and David Nolden.
> 
> 
> Description
> -------
> 
> As some of you will know, my master thesis was built on top of kdevelop with the idea to add some static analysis capabilities to KDevelop/KDevPlatform by adding some new tools and stuff. A document describing what I did can be found here: http://proli.net/meu/pfc/memoria.pdf
> 
> In this patch there's the changes I made in the KDevPlatform, mostly to add the DataAccessRepository and the ControlFlowGraph (Chapter 2) data types and the ILanguageCheck and ILanguageCheck provider (Chapter 3).
> 
> If there's any question just ask me :). I'll submit another patch for KDevelop, implementing these features shortly.
> 
> 
> Diffs
> -----
> 
>   language/CMakeLists.txt eb85b2c 
>   language/backgroundparser/parsejob.h 135319c 
>   language/checks/controlflowgraph.h PRE-CREATION 
>   language/checks/controlflowgraph.cpp PRE-CREATION 
>   language/checks/controlflownode.h PRE-CREATION 
>   language/checks/controlflownode.cpp PRE-CREATION 
>   language/checks/dataaccessrepository.h PRE-CREATION 
>   language/checks/dataaccessrepository.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103071/diff/diff
> 
> 
> Testing
> -------
> 
> Well, the testing is what I've built on top. It's coming, I'm just fixing some issues after merging from master. It wasn't as bad as I expected though ;).
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111108/80cd3570/attachment.html>