Review Request: Add moveFilesAndFolders to iprojectfilemanager fix ibuildsystemmanager's TargetFile usage

[Olivier Jean de Gaalon]

> On May 5, 2011, 2:19 a.m., Aleix Pol Gonzalez wrote:
> > project/abstractfilemanagerplugin.cpp, line 515
> > <http://git.reviewboard.kde.org/r/101234/diff/1/?file=15436#file15436line515>
> >
> >     Why don't you leave it abstract?
> >     This is ugly...

Oops, missed this one...

I can get rid of the qDebug(), of course, but I can't leave it abstract because the GenericManager inherits from the AbstractManager, and that function is pure virtual from IProjectFileManager.

Have a preference here?


- Olivier Jean de


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101234/#review3121
-----------------------------------------------------------


On April 26, 2011, 3:48 a.m., Olivier Jean de Gaalon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101234/
> -----------------------------------------------------------
> 
> (Updated April 26, 2011, 3:48 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Add moveFilesAndFolders function to iprojectfilemanager
> Add context-menu support for removing files from targets
> Add drag and drop support to model items
> Fix ibuildsystem manager to get rid of the TargetFile QPair
> 
> See also kdevelop patch.
> 
> 
> Diffs
> -----
> 
>   plugins/projectmanagerview/projectmanagerviewplugin.h 5f3e06f 
>   plugins/projectmanagerview/projectmanagerviewplugin.cpp b3cb948 
>   project/abstractfilemanagerplugin.h 3404744 
>   project/abstractfilemanagerplugin.cpp 6d23a15 
>   project/interfaces/ibuildsystemmanager.h eba6984 
>   project/interfaces/iprojectfilemanager.h aad8beb 
>   project/projectmodel.h d1cb3cc 
>   project/projectmodel.cpp 981bd3f 
>   shell/kross/xmltokross/dummybsm.h 5b8b0c6 
> 
> Diff: http://git.reviewboard.kde.org/r/101234/diff
> 
> 
> Testing
> -------
> 
> See kdevelop patch.
> 
> 
> Thanks,
> 
> Olivier Jean de
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110507/40d9d1f5/attachment.html>