Review Request: Add move support to cmake, refactor some CMakeLists/ChangesWidget handling bits.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101233/#review3123
-----------------------------------------------------------


Other than that, I think it's pretty good. Let's polish it a little further and we'll get it in before 4.3 :). Thanks!


projectmanagers/cmake/cmakemanager.cpp
<http://git.reviewboard.kde.org/r/101233/#comment2670>

    ¿?¿?¿? Why are you changing that? It's not correct



projectmanagers/cmake/cmakemanager.cpp
<http://git.reviewboard.kde.org/r/101233/#comment2671>

    Same here



projectmanagers/custommake/custommakemanager.h
<http://git.reviewboard.kde.org/r/101233/#comment2672>

    mec we shouldn't link to the shell here, probably just wrong include, use iproject.h


- Aleix


On April 26, 2011, 3:42 a.m., Olivier Jean de Gaalon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101233/
> -----------------------------------------------------------
> 
> (Updated April 26, 2011, 3:42 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Add move support to cmake, refactor some CMakeLists/ChangesWidget handling bits.
> 
> See also the KDevPlatform patch.
> 
> Apol:
> To preempt your question regarding the reloadFiles function...
> Given a a folder (say "folder3") within a folder (say "folder 2") within a folder (say "folder 1").
> If you move "folder 3" out of "folder 2", into "folder 1".
> ::reloadFiles will be called once, and will create a ProjectFolderItem for folder 1
> ::parse will be called once and will create a CMakeFolderItem for folder 1
> ::reloadFiles will be called towards the end of ::parse, loop through the project items in the folder, and check them against "entries"
> ::reloadFiles will find the ProjectFolderItem for "folder 1", and find the string in entries, and remove the string from entries
> ::reloadFiles will find the CMakeFolderItem for "folder 1", and NOT find the string in entries, and qDeleteAll(), removing both items
> ::reloadFiles will return to ::parse who will return a QList of the CMakeFolders it created, one of which was just deleted
> ImportProjectJob crashes.
> The changes to reload files prevent this crash
> 
> 
> Diffs
> -----
> 
>   languages/cpp/codegen/cppnewclass.cpp dc4036c 
>   projectmanagers/cmake/cmakemanager.h 78fa569 
>   projectmanagers/cmake/cmakemanager.cpp 054d488 
>   projectmanagers/custommake/custommakemanager.h 8c2d4d7 
>   projectmanagers/custommake/custommakemanager.cpp d025537 
> 
> Diff: http://git.reviewboard.kde.org/r/101233/diff
> 
> 
> Testing
> -------
> 
> {Adding, removing, moving} in {bulk, various nestings, one-by-one} to/from {targets, folders} repeatedly.
> 
> 
> Thanks,
> 
> Olivier Jean de
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110505/15e22410/attachment.html>