Review Request: Add moveFilesAndFolders to iprojectfilemanager fix ibuildsystemmanager's TargetFile usage

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101234/#review3121
-----------------------------------------------------------



project/abstractfilemanagerplugin.cpp
<http://git.reviewboard.kde.org/r/101234/#comment2667>

    Why don't you leave it abstract?
    This is ugly...



project/interfaces/iprojectfilemanager.h
<http://git.reviewboard.kde.org/r/101234/#comment2669>

    You mean to remove maybe?



project/projectmodel.h
<http://git.reviewboard.kde.org/r/101234/#comment2668>

    I don't really see why you need to have them sorted by URL.


- Aleix


On April 26, 2011, 3:48 a.m., Olivier Jean de Gaalon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101234/
> -----------------------------------------------------------
> 
> (Updated April 26, 2011, 3:48 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Add moveFilesAndFolders function to iprojectfilemanager
> Add context-menu support for removing files from targets
> Add drag and drop support to model items
> Fix ibuildsystem manager to get rid of the TargetFile QPair
> 
> See also kdevelop patch.
> 
> 
> Diffs
> -----
> 
>   plugins/projectmanagerview/projectmanagerviewplugin.h 5f3e06f 
>   plugins/projectmanagerview/projectmanagerviewplugin.cpp b3cb948 
>   project/abstractfilemanagerplugin.h 3404744 
>   project/abstractfilemanagerplugin.cpp 6d23a15 
>   project/interfaces/ibuildsystemmanager.h eba6984 
>   project/interfaces/iprojectfilemanager.h aad8beb 
>   project/projectmodel.h d1cb3cc 
>   project/projectmodel.cpp 981bd3f 
>   shell/kross/xmltokross/dummybsm.h 5b8b0c6 
> 
> Diff: http://git.reviewboard.kde.org/r/101234/diff
> 
> 
> Testing
> -------
> 
> See kdevelop patch.
> 
> 
> Thanks,
> 
> Olivier Jean de
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110505/8d8d2e16/attachment.html>