Review Request: connect return value tested instead of errno

[Aleix Pol Gonzalez]

> On March 28, 2011, 9:13 a.m., Andrey Batyiev wrote:
> > There are too many trailing whitespace removal - somewhat harder to read.
> > Except that it seems it's a good fix.

+1
Please cleanup your patches and don't commit whitespace changes before committing and asking for review.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100959/#review2203
-----------------------------------------------------------


On March 27, 2011, 4:44 p.m., Lambert CLARA wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100959/
> -----------------------------------------------------------
> 
> (Updated March 27, 2011, 4:44 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> The connect() system call returns 0 if successful, and if not returns -1 and sets errno.
> The return value of connect was tested instead of errno, this patch fixes that.
> 
> 
> Diffs
> -----
> 
>   util/dbus_socket_transformer/main.cpp 17019ce 
> 
> Diff: http://git.reviewboard.kde.org/r/100959/diff
> 
> 
> Testing
> -------
> 
> Compilation only.
> 
> 
> Thanks,
> 
> Lambert
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110328/0b79a564/attachment.html>