Review Request: Respect parent constructor aruments when code-completing a constructor implementation

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100924/#review2200
-----------------------------------------------------------

Ship it!


fine with me, ++ for the unit test fixup, now we should write more unit tests for all those helpers...

- Milian


On March 22, 2011, 10:39 p.m., Dmitry Risenberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100924/
> -----------------------------------------------------------
> 
> (Updated March 22, 2011, 10:39 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Try to match parent class constructor arguments as good as possible, first by type and then by name. If parent class has multiple constructors, try to find the one that matches the best to this class' constructor arguments.
> 
> 
> This addresses bug 255038.
>     http://bugs.kde.org/show_bug.cgi?id=255038
> 
> 
> Diffs
> -----
> 
>   languages/cpp/codecompletion/context.cpp 651779f 
>   languages/cpp/codecompletion/implementationhelperitem.cpp fd29e4a 
>   languages/cpp/tests/test_cppcodecompletion.h dcc975c 
>   languages/cpp/tests/test_cppcodecompletion.cpp ab61271 
> 
> Diff: http://git.reviewboard.kde.org/r/100924/diff
> 
> 
> Testing
> -------
> 
> Unit tests + example from bug report.
> 
> 
> Thanks,
> 
> Dmitry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110328/6f806785/attachment.html>