Review Request: Add buddy document functionality to cpp plugin

[Dmitry Risenberg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100796/#review2157
-----------------------------------------------------------


Cannot compile this:

In file included from /data/commando/Development/KDE/kdevelop/languages/cpp/codecompletion/context.cpp:48:0:                                                 
/data/commando/Development/KDE/kdevelop/languages/cpp/codecompletion/../cpplanguagesupport.h:28:45: fatal error: interfaces/ibuddydocumentfinder.h: No such file or directory

Probably this is because https://git.reviewboard.kde.org/r/100795/ wasn't properly updated after splitting in two.


languages/cpp/cpplanguagesupport.cpp
<http://git.reviewboard.kde.org/r/100796/#comment1782>

    Isn't the list of mimetypes already stored somewhere inside IPlugin?



languages/cpp/cpplanguagesupport.cpp
<http://git.reviewboard.kde.org/r/100796/#comment1783>

    Use QFileInfo class instead of computing filename and extension on your own, but (see below)



languages/cpp/cpplanguagesupport.cpp
<http://git.reviewboard.kde.org/r/100796/#comment1784>

    I think it would be better to look at mimetypes, not file extensions, because 
    1) Your code recognizes *.cs as a buddy.
    2) There can be weird extensions, such as .inl, .tcc and so on.


- Dmitry


On March 18, 2011, 2:42 p.m., Yannick Motta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100796/
> -----------------------------------------------------------
> 
> (Updated March 18, 2011, 2:42 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Add buddy document functionality to cpp plugin.
> Related to "Add smart clean up and buddy document architecture" review request (https://git.reviewboard.kde.org/r/100795/ )
> Cpp plugin implements IBuddyDocumentFinder. foo.h an foo.cpp are buddies and the header will be placed on the left of the cpp.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cpplanguagesupport.h a1736d6 
>   languages/cpp/cpplanguagesupport.cpp 7f28518 
> 
> Diff: http://git.reviewboard.kde.org/r/100796/diff
> 
> 
> Testing
> -------
> 
> See other review.
> 
> 
> Thanks,
> 
> Yannick
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110324/15661855/attachment.html>