Review Request: Allow to mark Declaration instances as "automatically created"

Sven Brauch svenbrauch at gmx.de
Thu Mar 24 02:04:05 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100936/
-----------------------------------------------------------

(Updated March 24, 2011, 2:04 a.m.)


Review request for KDevelop.


Changes
-------

Hi David,

I hope this is about what you meant; at least it seems to work (no disappearing declarations so far).
I'm not sure if checking for weather indexForUsedDeclaration() already has been created or not is sufficient for checking weather a declaration has uses or not.

Cheers,
Sven


Summary
-------

Allow to mark Declaration instances as "automatically created", so they aren't automatically deleted if they weren't encountered while the context containing them was generated. This is useful for languages like python and php, where you can do something like "foo = A(); foo.x=3" without having defined a property named x in the class A previously.
I'm not sure about the change in ducontext.cpp; maybe that will be too slow, I don't know.


Diffs (updated)
-----

  language/duchain/declaration.h 92e0c62 
  language/duchain/declaration.cpp b46e4f1 
  language/duchain/declarationdata.h 3ae64ba 
  language/duchain/ducontext.h 9e7b75b 
  language/duchain/ducontext.cpp 3ec527b 
  language/duchain/repositories/itemrepository.cpp c76befd 
  language/duchain/uses.h 7f9b90a 
  language/duchain/uses.cpp d1fedee 

Diff: http://git.reviewboard.kde.org/r/100936/diff


Testing
-------


Thanks,

Sven

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110324/30bbd41c/attachment.html>


More information about the KDevelop-devel mailing list