Review Request: Add possibility to force DeclarationIds to be always direct

David Nolden david.nolden.kde at art-master.de
Wed Mar 23 10:03:17 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100875/#review2118
-----------------------------------------------------------


No objection, if you also increase the repository version value (see my last comment).

- David


On March 20, 2011, 10:48 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100875/
> -----------------------------------------------------------
> 
> (Updated March 20, 2011, 10:48 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> As suggested by David on the mailing list, this patch adds the possibility to force a DeclarationId to be always "direct", making correct reporting of uses possible for contexts which are imported into the InternalContext of a newly created Declaration, as required for the python language plugin (at least I couldn't find another working solution). It adds a 1-bit boolean to the DeclarationData class, hope that's not a problem.
> 
> 
> Diffs
> -----
> 
>   language/duchain/declaration.h 77abb95 
>   language/duchain/declaration.cpp ce70ff3 
>   language/duchain/declarationdata.h f02a9b1 
> 
> Diff: http://git.reviewboard.kde.org/r/100875/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sven
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110323/046749d5/attachment.html>


More information about the KDevelop-devel mailing list