Review Request: Respect parent constructor aruments when code-completing a constructor implementation

Dmitry Risenberg dmitry.risenberg at gmail.com
Tue Mar 22 22:39:44 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100924/
-----------------------------------------------------------

Review request for KDevelop.


Summary
-------

Try to match parent class constructor arguments as good as possible, first by type and then by name. If parent class has multiple constructors, try to find the one that matches the best to this class' constructor arguments.


This addresses bug 255038.
    http://bugs.kde.org/show_bug.cgi?id=255038


Diffs
-----

  languages/cpp/codecompletion/context.cpp 651779f 
  languages/cpp/codecompletion/implementationhelperitem.cpp fd29e4a 
  languages/cpp/tests/test_cppcodecompletion.h dcc975c 
  languages/cpp/tests/test_cppcodecompletion.cpp ab61271 

Diff: http://git.reviewboard.kde.org/r/100924/diff


Testing
-------

Unit tests + example from bug report.


Thanks,

Dmitry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110322/e2e9b010/attachment.html>


More information about the KDevelop-devel mailing list