Review Request: Add possibility to force DeclarationIds to be always direct

Sven Brauch svenbrauch at gmx.de
Sun Mar 20 22:48:56 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100875/
-----------------------------------------------------------

(Updated March 20, 2011, 10:48 p.m.)


Review request for KDevelop.


Changes
-------

The previously submitted patch had a serious bug, leading to the added property not being saved to disk, and thus leading to strange errors and crashes on loading it. This update fixes that problem.


Summary
-------

As suggested by David on the mailing list, this patch adds the possibility to force a DeclarationId to be always "direct", making correct reporting of uses possible for contexts which are imported into the InternalContext of a newly created Declaration, as required for the python language plugin (at least I couldn't find another working solution). It adds a 1-bit boolean to the DeclarationData class, hope that's not a problem.


Diffs (updated)
-----

  language/duchain/declaration.h 77abb95 
  language/duchain/declaration.cpp ce70ff3 
  language/duchain/declarationdata.h f02a9b1 

Diff: http://git.reviewboard.kde.org/r/100875/diff


Testing
-------


Thanks,

Sven

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110320/d86de6ab/attachment.html>


More information about the KDevelop-devel mailing list