Review Request: Improvement of "Find in Files" dialog to save template strings

[Steffen Ohrendorf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100877/
-----------------------------------------------------------

(Updated March 18, 2011, 12:23 p.m.)


Review request for KDevelop.


Changes
-------

removed commented lines and fixed also a possible bug


Summary
-------

This patch replaces the "line edit" in the "find in files" dialog by a KComboBox, so that all used patterns are saved between sessions, not only the last used one.

The bug is related, though not fully resolved. "Named templates" would be a todo for the future.


This addresses bug 112381.
    http://bugs.kde.org/show_bug.cgi?id=112381


Diffs (updated)
-----

  plugins/grepview/grepdialog.cpp 41cc012 
  plugins/grepview/grepwidget.ui 50c871f 

Diff: http://git.reviewboard.kde.org/r/100877/diff


Testing
-------

Autocompletion of input and saving between sessions works for me.


Screenshots
-----------

Effect of the patch
  http://git.reviewboard.kde.org/r/100877/s/105/


Thanks,

Steffen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110318/b1b36ad9/attachment.html>