Review Request: Fix order of handling of command results in GDB plugin.

[Dmitry Risenberg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100831/
-----------------------------------------------------------

(Updated March 20, 2011, 7:58 p.m.)


Review request for KDevelop.


Changes
-------

Wrote a unit test - an "Internal Debugger Error" dialog pops up when it is run.


Summary
-------

This patch stores the commands sent to GDB via MI in a queue and applies all output to the queue head. When a result record is received, the queue head is popped.

This fixes a bug: when running GDB debugging sessions in KDevelop, sometimes the "Internal debugger error" message box pops up with "^done" or "^error".
This happens when multiple commands are submitted to GDB (one of them from text hint for variable, for example), and one of them receives the result intended for another one. Could not reliably reproduce this, but often happens when breaking in AStylePlugin::formatSourceWithStyle and stepping through it. That could also be a reason for hanging of GDB when 'ready_for_next_command' does not get set correctly.

Btw, I think GDB::processLine might be improved even more, by distinguishing which types of output do need a command and which do not. Also, is 'ready_for_next_command' necessary at all now?


Diffs (updated)
-----

  debuggers/gdb/unittests/gdbtest.h e0eccc7 
  debuggers/gdb/unittests/gdbtest.cpp 5cfc6b1 

Diff: http://git.reviewboard.kde.org/r/100831/diff


Testing
-------

Manually tested scenario that previously often produced the "Internal debugger error" message.


Thanks,

Dmitry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110320/9b42e8d7/attachment.html>