Review Request: Make VcsCommitDialog useful as fallback, when no PatchReview plugin loaded

[Andrey Batyiev]

> On March 18, 2011, 12:48 a.m., Aleix Pol Gonzalez wrote:
> > vcs/vcspluginhelper.cpp, line 416
> > <http://git.reviewboard.kde.org/r/100885/diff/1/?file=11540#file11540line416>
> >
> >     Who is going to delete it now? maybe we can put it in a QSharedPointer?

Inside finishReview and cancelReview slots of VCSCommitDiffPatchSource.


> On March 18, 2011, 12:48 a.m., Aleix Pol Gonzalez wrote:
> > vcs/vcspluginhelper.cpp, line 388
> > <http://git.reviewboard.kde.org/r/100885/diff/1/?file=11540#file11540line388>
> >
> >     That change is unrelated and shouldn't be part of the patch. (Although it's a good change)

It used in commitDialog->setCommitCandidates(varlist); on line 409 (further in file).


- Andrey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100885/#review2026
-----------------------------------------------------------


On March 17, 2011, 11:04 p.m., Andrey Batyiev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100885/
> -----------------------------------------------------------
> 
> (Updated March 17, 2011, 11:04 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Most of the code was stripped and reworked to use IPatchSource, which is been built inside VcsPluginHelper::commit() => bunch of code was removed due to deduplication.
> 1. building of VCSCommitDiffPatchSource inside commit()
> 2. vcs messages handling changed to use VCSCommitDiffPatchSource provided custom widget
> 3. commit handling changed to use VCSCommitDiffPatchSource review facilities
> 
> 
> This addresses bug 267578.
>     http://bugs.kde.org/show_bug.cgi?id=267578
> 
> 
> Diffs
> -----
> 
>   vcs/vcspluginhelper.cpp c9c3902 
>   vcs/widgets/vcscommitdialog.h 89291b9 
>   vcs/widgets/vcscommitdialog.cpp d471353 
>   vcs/widgets/vcscommitdialog.ui 6305bea 
> 
> Diff: http://git.reviewboard.kde.org/r/100885/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110319/ffd3c5ff/attachment.html>