Review Request: Debug tooltip overlap

Milian Wolff mail at milianw.de
Fri Mar 18 10:57:06 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100840/#review2032
-----------------------------------------------------------

Ship it!


please merge both patches

- Milian


On March 11, 2011, 1:09 p.m., Julien Desgats wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100840/
> -----------------------------------------------------------
> 
> (Updated March 11, 2011, 1:09 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> This little patch fixes the overlapping problem with debug tooltips. According to what we said in ML some months ago (topic "Debugger and duchain hints overlaps") debug tooltips are shown only on debug area. 
> 
> However, using ActiveToolTip::showToolTip instead of just show() avoids overlap, so we could also show both tooltips, replace "ActiveToolTip::showToolTip(this, 0.0);" by "ActiveToolTip::showToolTip(this, 1.0);" to see the result. The debug tooltip will be displayed before navigation tooltip, which will be unreachable (it will disappear as soon as the cursor move).
> 
> When working on that, I discover that ActiveToolTip::showToolTip does not behave like the documentation says (for exclusive mode), see bug link. In order to work correctly, this patch need bug patch too.
> 
> 
> This addresses bug 268196.
>     http://bugs.kde.org/show_bug.cgi?id=268196
> 
> 
> Diffs
> -----
> 
>   debugger/variable/variablecollection.cpp 5edd4a9 
>   debugger/variable/variabletooltip.cpp 58ce558 
>   interfaces/iuicontroller.h 49d5a10 
> 
> Diff: http://git.reviewboard.kde.org/r/100840/diff
> 
> 
> Testing
> -------
> 
> Test debugging with some projects.
> 
> 
> Thanks,
> 
> Julien
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110318/3a1931d8/attachment.html>


More information about the KDevelop-devel mailing list