Review Request: Add possibility to force DeclarationIds to be always direct

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100875/#review2031
-----------------------------------------------------------

Ship it!


seems to be straight forward, the comment needs some work though (imo)


language/duchain/declaration.h
<http://git.reviewboard.kde.org/r/100875/#comment1706>

    this comment is misleading imo.
    
    Better make it:
    
    "@param forceDirect When ... and top-context.
    The same goes for Declarations that have @c alwaysForceDirect() set to true."


- Milian


On March 16, 2011, 9:47 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100875/
> -----------------------------------------------------------
> 
> (Updated March 16, 2011, 9:47 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> As suggested by David on the mailing list, this patch adds the possibility to force a DeclarationId to be always "direct", making correct reporting of uses possible for contexts which are imported into the InternalContext of a newly created Declaration, as required for the python language plugin (at least I couldn't find another working solution). It adds a 1-bit boolean to the DeclarationData class, hope that's not a problem.
> 
> 
> Diffs
> -----
> 
>   language/duchain/declaration.h 77abb95 
>   language/duchain/declaration.cpp ce70ff3 
>   language/duchain/declarationdata.h f02a9b1 
> 
> Diff: http://git.reviewboard.kde.org/r/100875/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sven
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110318/3b1ef78f/attachment.html>