Review Request: Make VcsCommitDialog useful as fallback, when no PatchReview plugin loaded

Andrey Batyiev batyiev at gmail.com
Thu Mar 17 23:04:25 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100885/
-----------------------------------------------------------

Review request for KDevelop.


Summary
-------

Most of the code was stripped and reworked to use IPatchSource, which is been built inside VcsPluginHelper::commit() => bunch of code was removed due to deduplication.
1. building of VCSCommitDiffPatchSource inside commit()
2. vcs messages handling changed to use VCSCommitDiffPatchSource provided custom widget
3. commit handling changed to use VCSCommitDiffPatchSource review facilities


This addresses bug 267578.
    http://bugs.kde.org/show_bug.cgi?id=267578


Diffs
-----

  vcs/vcspluginhelper.cpp c9c3902 
  vcs/widgets/vcscommitdialog.h 89291b9 
  vcs/widgets/vcscommitdialog.cpp d471353 
  vcs/widgets/vcscommitdialog.ui 6305bea 

Diff: http://git.reviewboard.kde.org/r/100885/diff


Testing
-------


Thanks,

Andrey

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110317/60a389bf/attachment.html>


More information about the KDevelop-devel mailing list