Review Request: Make formatter settings configurable per language instead of mimetype

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100868/#review2018
-----------------------------------------------------------

Ship it!


awesome work, please merge

- Milian


On March 17, 2011, 8:29 p.m., Dmitry Risenberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100868/
> -----------------------------------------------------------
> 
> (Updated March 17, 2011, 8:29 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> This patch makes formatter settings configurable per language, not mimetype (see screenshot). Language <-> mimetype mapping is taken from LanguageController.
> 
> Also changed the relations between languages, formatters and styles - now all the languages share the same style object for a style with same name, so if it is changed for one language, other languages will see the change too.
> 
> Need to clarify whether there can be no styles for a formatter (a TODO in code). With current plugins this is not the case, but is it possible at all? If it is, what should be done if this formatter is selected?
> 
> 
> This addresses bug 230472.
>     http://bugs.kde.org/show_bug.cgi?id=230472
> 
> 
> Diffs
> -----
> 
>   shell/languagecontroller.h 3bb9cf43af76b073a1c01ae29c3bd5299c5928ac 
>   shell/languagecontroller.cpp 283c7e720eb5ab67ded953f07a8949d84d1e4485 
>   shell/settings/CMakeLists.txt edcf49c4f22f4b94bcffe93f9de74fbf18c2a2f4 
>   shell/settings/sourceformattersettings.h c7c2a0ebfa075bae94215d1adb585a4f42bcd8a4 
>   shell/settings/sourceformattersettings.cpp 15060c7417af7dfe5400cd4e1e738b1c974d6d54 
>   shell/settings/sourceformattersettings.ui cc5e55c6b7d6df16f0dec09b07d63f00c7a3f128 
> 
> Diff: http://git.reviewboard.kde.org/r/100868/diff
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Screenshots
> -----------
> 
> Selecting language
>   http://git.reviewboard.kde.org/r/100868/s/104/
> 
> 
> Thanks,
> 
> Dmitry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110317/087e0ddf/attachment.html>