Review Request: Make formatter settings configurable per language instead of mimetype

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100868/#review1986
-----------------------------------------------------------



shell/settings/sourceformattersettings.cpp
<http://git.reviewboard.kde.org/r/100868/#comment1667>

    this is a no-go, there is e.g. a php formatter in quanta which would break this.
    
    generally, code that is extensible via plugins must not assume such code paths nor do such hardcoded stuff to begin with.
    
    this needs a proper design. as it requires string changes it cannot go into 4.2 anyways, hence do it properly from the beginning please.
    
    I'll think about it and add my ideas these days, please remind me.


- Milian


On March 15, 2011, 10:23 p.m., Dmitry Risenberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100868/
> -----------------------------------------------------------
> 
> (Updated March 15, 2011, 10:23 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> This patch makes formatter settings configurable per language, not mimetype (see screenshot). Currently mime <-> language mapping is hard-coded (this should be fixed somehow, suggestions are welcome).
> 
> Also changed the relations between languages, formatters and styles - now all the languages share the same style object for a style with same name, so if it is changed for one language, other languages will see the change too.
> 
> Need to clarify whether there can be no styles for a formatter (a TODO in code). With current plugins this is not the case, but is it possible at all? If it is, what should be done if this formatter is selected?
> 
> 
> This addresses bug 230472.
>     http://bugs.kde.org/show_bug.cgi?id=230472
> 
> 
> Diffs
> -----
> 
>   shell/settings/sourceformattersettings.h c7c2a0ebfa075bae94215d1adb585a4f42bcd8a4 
>   shell/settings/sourceformattersettings.cpp 15060c7417af7dfe5400cd4e1e738b1c974d6d54 
>   shell/settings/sourceformattersettings.ui cc5e55c6b7d6df16f0dec09b07d63f00c7a3f128 
> 
> Diff: http://git.reviewboard.kde.org/r/100868/diff
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Screenshots
> -----------
> 
> Selecting language
>   http://git.reviewboard.kde.org/r/100868/s/99/
> 
> 
> Thanks,
> 
> Dmitry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110315/0e3e544b/attachment.html>