Review Request: Remove unnecessary code in abstractusebuilder.h

[Floris Ruijter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100862/#review1980
-----------------------------------------------------------

Ship it!


if there's no other reason for having this bool, then it should be removed. perhaps it was useful at sometime but a branch got removed?

- Floris


On March 15, 2011, 12:21 a.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100862/
> -----------------------------------------------------------
> 
> (Updated March 15, 2011, 12:21 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Just stumbled about this apparently pointless bool (it's created locally, but never changed and once checked with if ( ! encountered ), which is always true). Trying to understand the code it is involved in, I find it confusing, so I'd propose to remove it.
> 
> 
> Diffs
> -----
> 
>   language/duchain/builders/abstractusebuilder.h ff8f44e 
> 
> Diff: http://git.reviewboard.kde.org/r/100862/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sven
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110315/1b7f0a99/attachment.html>