Review Request: Add buddy document functionality to cpp plugin

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100796/#review1918
-----------------------------------------------------------



languages/cpp/CMakeLists.txt
<http://git.reviewboard.kde.org/r/100796/#comment1616>

    as I've commented in the other review, this should be removed again and the ifaces moved to kdevplatform and shell



languages/cpp/cpplanguagesupport.h
<http://git.reviewboard.kde.org/r/100796/#comment1614>

    using? what for? inheriting should be sufficient.



languages/cpp/cpplanguagesupport.cpp
<http://git.reviewboard.kde.org/r/100796/#comment1615>

    remove this and query the plugins' meta data somehow, the .desktop already includes a mimetype list


- Milian


On March 10, 2011, 7:25 p.m., Yannick Motta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100796/
> -----------------------------------------------------------
> 
> (Updated March 10, 2011, 7:25 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Add buddy document functionality to cpp plugin.
> Related to "Add smart clean up and buddy document architecture" review request (https://git.reviewboard.kde.org/r/100795/)
> Cpp plugin implements IBuddyDocumentFinder. foo.h an foo.cpp are buddies and the header will be placed on the left of the cpp.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/CMakeLists.txt 571210d 
>   languages/cpp/cpplanguagesupport.h a1736d6 
>   languages/cpp/cpplanguagesupport.cpp 7f28518 
> 
> Diff: http://git.reviewboard.kde.org/r/100796/diff
> 
> 
> Testing
> -------
> 
> See other review.
> 
> 
> Thanks,
> 
> Yannick
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110312/f86e23e7/attachment.html>