Review Request: Fix file(GLOB) and FILE(GLOB_RECURSE) implementations, add appropriate tests

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100283/#review1838
-----------------------------------------------------------

Ship it!


Sorry for being so slow at answering that.
Can you please provide a patch that I can use to commit right away? Git rejects your patch here :/

- Aleix


On Jan. 3, 2011, 4:19 p.m., Valentyn Pavliuchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100283/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2011, 4:19 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Both file(GLOB) and file(GLOB_RECURSE) parsers were fixed to behave as CMake does (reimplemented properly). Added FOLLOW_SYMLINKS parameter to GLOB_RECURSE. Fixed RELATIVE behavior. Added glob expressions support in directory names in the path, as CMake supports it.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/parser/cmakeast.h 54a52d0 
>   projectmanagers/cmake/parser/cmakeast.cpp 7e40013 
>   projectmanagers/cmake/parser/cmakedebugvisitor.cpp 03a0d8c 
>   projectmanagers/cmake/parser/cmakeprojectvisitor.h a825d2b 
>   projectmanagers/cmake/parser/cmakeprojectvisitor.cpp e2f16d1 
>   projectmanagers/cmake/tests/cmake_cmakeprojectvisitor_test.h b16b16f 
>   projectmanagers/cmake/tests/cmake_cmakeprojectvisitor_test.cpp 638b7d0 
> 
> Diff: http://git.reviewboard.kde.org/r/100283/diff
> 
> 
> Testing
> -------
> 
> Done manual testing. Added appropriate unit test. Unit test passed.
> 
> 
> Thanks,
> 
> Valentyn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110308/1b3b0f07/attachment.html>