Review Request: Remove inconsistency in BackgroundParser internal state

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100807/#review1795
-----------------------------------------------------------



language/backgroundparser/backgroundparser.cpp
<http://git.reviewboard.kde.org/r/100807/#comment1480>

    Q_ASSERT(m_documents.contains(*it));



language/backgroundparser/backgroundparser.cpp
<http://git.reviewboard.kde.org/r/100807/#comment1481>

    const DocumentParsePlan& parsePlan = m_documents[*it];



language/backgroundparser/backgroundparser.cpp
<http://git.reviewboard.kde.org/r/100807/#comment1482>

    is this required or just done to prevent that bug you linked to?
    
    I wonder because afair urls passed to the background parser are not supposed to be relative! hence the description in that bug report you linked to does not apply?


- Milian


On March 6, 2011, 1:51 a.m., Dmitry Risenberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100807/
> -----------------------------------------------------------
> 
> (Updated March 6, 2011, 1:51 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> When a document was added for parsing with multiple priorities, a default DocumentParsePlan was retrieved from m_documents when creating jobs after the first one. This led to incorrect set of features for parsing job and might trigger unnecessary reparsing when a file was reloaded.
> 
> Changed m_documents from QMap to QHash to avoid hitting https://bugs.kde.org/show_bug.cgi?id=267732.
> 
> 
> Diffs
> -----
> 
>   language/backgroundparser/backgroundparser.cpp 540a453e74d4a518e54bc9b5fa0c982d76088ea1 
> 
> Diff: http://git.reviewboard.kde.org/r/100807/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110306/b001bd6c/attachment.html>