Review Request: Promote cpp parsing job features to slave features when the latter are not satisfied

Milian Wolff mail at milianw.de
Sun Mar 6 02:20:17 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100798/#review1794
-----------------------------------------------------------



languages/cpp/preprocessjob.cpp
<http://git.reviewboard.kde.org/r/100798/#comment1479>

    imo: if it's really that strange, use a kWarning so this is actually spotted


- Milian


On March 6, 2011, 1:56 a.m., Dmitry Risenberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100798/
> -----------------------------------------------------------
> 
> (Updated March 6, 2011, 1:56 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> If a parse job had fewer features for the source file than for its imports, it would cause a reparse of that source each time it is loaded, regardless of whether anything has changed in it (recent discussion in the ML).
> 
> 
> Diffs
> -----
> 
>   languages/cpp/preprocessjob.cpp 9149eee30a11fa7a2d85e987e719265597c7e594 
> 
> Diff: http://git.reviewboard.kde.org/r/100798/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110306/1a846a12/attachment.html>


More information about the KDevelop-devel mailing list