Review Request: Fix standard include dirs and macros under Windows

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100801/#review1779
-----------------------------------------------------------

Ship it!


please add at least the comment to the msvcdefinehelper.cpp then I'm ok. the rest is more suggestions than requests for changes.

thanks


languages/cpp/CMakeLists.txt
<http://git.reviewboard.kde.org/r/100801/#comment1473>

    what about only adding the _gcc version in the else branch?



languages/cpp/msvcdefinehelper.cpp
<http://git.reviewboard.kde.org/r/100801/#comment1471>

    a comment explaining why this file is required and what it does (basically what you wrote in the review description) would be good



languages/cpp/setuphelpers.cpp
<http://git.reviewboard.kde.org/r/100801/#comment1474>

    isn't this missing the extern keyword?
    
    and I'd personally use the #if MSC_VER here already



languages/cpp/setuphelpers.cpp
<http://git.reviewboard.kde.org/r/100801/#comment1472>

    make this a ///TODO: ...


- Milian


On March 5, 2011, 4:21 p.m., Andreas Holzammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100801/
> -----------------------------------------------------------
> 
> (Updated March 5, 2011, 4:21 p.m.)
> 
> 
> Review request for KDevelop, kdewin, Milian Wolff, and Patrick Spendrin.
> 
> 
> Summary
> -------
> 
> This patch enables Kdevelop to find the include directories and standard macros under Windows.
> 
> There is no "gcc -dM -E -" under Windows. So you need to do a hack to find the standard defined macros. Therefore a empty cpp file is compiled with a special commandline option "/Bx" to replace the compiler against a program which interpretes the output of the preprocessor.
> 
> For include directories Windows uses enviroment variables, so this patch processes them.
> 
> This patch has been written by Patrick Spenderin, thank you for that.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/CMakeLists.txt e7c3c0c07ac3ac0ad5b49c60b0d0c279b77e8e75 
>   languages/cpp/msvcdefinehelper.cpp PRE-CREATION 
>   languages/cpp/setuphelpers.cpp b35ec8386a2c04a7caa421be9bf8e0d268f1213a 
>   languages/cpp/setuphelpers_gcc.cpp PRE-CREATION 
>   languages/cpp/setuphelpers_msvc.cpp PRE-CREATION 
>   languages/cpp/tests/CMakeLists.txt e3b7add33e9f89b96ae8f86da3cc240647cd99a4 
> 
> Diff: http://git.reviewboard.kde.org/r/100801/diff
> 
> 
> Testing
> -------
> 
> tested it with Windows 7 Ultimate x64 with KDE Windows trunk compiled with MSVC 2010. Works so far.
> 
> 
> Thanks,
> 
> Andreas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110305/a0b6192d/attachment.html>