Review Request: Promote cpp parsing job features to slave features when the latter are not satisfied

[David Nolden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100798/#review1778
-----------------------------------------------------------


I'm not entirely sure if this is the right fix. The question is, where do these features come from? Why are the features requested for children higher than for the file itself? Maybe we use too high features for the children by default (see CppParseJob::slaveMinimumFeatures and CPPParseJob::standardMinimumFeatures).

- David


On March 4, 2011, 11:59 p.m., Dmitry Risenberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100798/
> -----------------------------------------------------------
> 
> (Updated March 4, 2011, 11:59 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> If a parse job had fewer features for the source file than for its imports, it would cause a reparse of that source each time it is loaded, regardless of whether anything has changed in it (recent discussion in the ML).
> 
> 
> Diffs
> -----
> 
>   languages/cpp/preprocessjob.cpp 9149eee30a11fa7a2d85e987e719265597c7e594 
> 
> Diff: http://git.reviewboard.kde.org/r/100798/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110305/864d6209/attachment.html>