Review Request: Add smart clean up and buddy document architecture

Sat Mar 5 10:45:08 UTC 2011

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100795/#review1774
-----------------------------------------------------------

This does not apply cleanly on current master:

patching file sublime/container.h
Hunk #2 FAILED at 63.
1 out of 2 hunks FAILED -- saving rejects to file sublime/container.h.rej
patching file sublime/container.cpp
Hunk #9 succeeded at 519 with fuzz 2 (offset 12 lines).

Please rebase on current master branch and re-send the patch.

Also the whitespace and newline changes make it hard to see what has actually changed. Some new trailing whitespaces are introduced - they should be removed.

Replace 'buddys' with 'buddies' - this is the correct spelling.

I think IBuddyDocumentFinder should be not in sublime, but in interfaces, because C++ support should not depend on the UI library (your other patch).

As a feature request: this should sometimes be triggered automatically, for example on closing KDevelop (whether to trigger or not can be configured in the settings).

kdevplatform.kdev4
<http://git.reviewboard.kde.org/r/100795/#comment1457>

    Project file should not be removed.

shell/documentcontroller.h
<http://git.reviewboard.kde.org/r/100795/#comment1458>

    Why does this belong to IDocumentController and not IBuddyDocumentFinder?

shell/documentcontroller.cpp
<http://git.reviewboard.kde.org/r/100795/#comment1459>

    buddys -> buddies

shell/settings/uipreferences.cpp
<http://git.reviewboard.kde.org/r/100795/#comment1460>

    Please revert

shell/tests/documentcontrollertest.cpp
<http://git.reviewboard.kde.org/r/100795/#comment1462>

    What do you mean by this?

shell/tests/documentcontrollertest.cpp
<http://git.reviewboard.kde.org/r/100795/#comment1463>

    Either uncomment or remove this.

shell/tests/documentcontrollertest.cpp
<http://git.reviewboard.kde.org/r/100795/#comment1461>

    Why are these commented out? If you expect them to pass, but they don't for now, use QEXPECT_FAIL.

sublime/container.cpp
<http://git.reviewboard.kde.org/r/100795/#comment1470>

    Just "Cleanup" will be better.

sublime/container.cpp
<http://git.reviewboard.kde.org/r/100795/#comment1469>

    Need multiple here.

sublime/tests/areaoperationtest.cpp
<http://git.reviewboard.kde.org/r/100795/#comment1468>

    Trailing whitespace.

sublime/tests/areaoperationtest.cpp
<http://git.reviewboard.kde.org/r/100795/#comment1467>

    Trailing whitespace.

- Dmitry

On March 4, 2011, 5:31 p.m., Yannick Motta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100795/
> -----------------------------------------------------------
> 
> (Updated March 4, 2011, 5:31 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Add document buddy architecture :
> Allow kdevelop language plugins to manage related documents (like foo.h and foo.cpp for cpp plugin)
> Language plugins may implement IBuddyDocumentFinder to define the rules (how to know if two documents are buddies).
> Language plugins that implement IBuddyDocumentFinder  must register themselves with BuddyFinderRegistry.
> An option was added to open documents side by side with its buddies.
> 
> Add smart cleanup feature to allow user to easily close outdated tabs related to each tab-bar.
> Outdated tabs are files that are not currently used.
> This feature is configurable, user can choose the time after which smart cleanup considers an unused tab outdated.
> An document is considered active if it is active at least five seconds.
> Last five documents are never outdated. 
> If an outdated document has an active buddy, it is immune to cleanup.
> User must manually start cleanup feature on the context menu of the tab-bar.
> A dialog opens and user can see which documents are considered outdated. User can remove documents from the list.
> If the user clicks "ok", tabs will be close.
> 
> Add an option to hide close buttons on tabs in order to free some space.
> 
> 
> Diffs
> -----
> 
>   interfaces/idocumentcontroller.h d036afa 
>   kdevplatform.kdev4 f5f408c 
>   project/CMakeLists.txt a5b7f74 
>   shell/documentcontroller.h 8dc3706 
>   shell/documentcontroller.cpp bc0a3dd 
>   shell/settings/uiconfig.kcfg 60dccb2 
>   shell/settings/uiconfig.kcfgc 3c02f72 
>   shell/settings/uiconfig.ui 61f4b08 
>   shell/settings/uipreferences.cpp 43c63d6 
>   shell/tests/CMakeLists.txt b093565 
>   shell/tests/documentcontrollertest.h PRE-CREATION 
>   shell/tests/documentcontrollertest.cpp PRE-CREATION 
>   shell/tests/shellbuddytest.h PRE-CREATION 
>   shell/tests/shellbuddytest.cpp PRE-CREATION 
>   sublime/CMakeLists.txt f9aaaeb 
>   sublime/area.h df0e2bb 
>   sublime/area.cpp efa8025 
>   sublime/buddyfinderregistry.h PRE-CREATION 
>   sublime/buddyfinderregistry.cpp PRE-CREATION 
>   sublime/cleanup.h PRE-CREATION 
>   sublime/cleanup.cpp PRE-CREATION 
>   sublime/cleanupdialog.h PRE-CREATION 
>   sublime/cleanupdialog.cpp PRE-CREATION 
>   sublime/cleanupdialog.ui PRE-CREATION 
>   sublime/container.h 6b79df7 
>   sublime/container.cpp d45604f 
>   sublime/controller.h e8b4794 
>   sublime/controller.cpp a8dd38a 
>   sublime/ibuddydocumentfinder.h PRE-CREATION 
>   sublime/mainwindow.cpp 08ca648 
>   sublime/tests/CMakeLists.txt 410412b 
>   sublime/tests/areaoperationtest.h 0e0f08e 
>   sublime/tests/areaoperationtest.cpp 28dbeff 
>   sublime/tests/cleanuptest.h PRE-CREATION 
>   sublime/tests/cleanuptest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100795/diff
> 
> 
> Testing
> -------
> 
> We have added two unit tests :
> sublime-cleanuptest
> shell-buddytest
> both pass without error.
> manual test seems also working as expected.
> 
> 
> Screenshots
> -----------
> 
> New ui settings
>   http://git.reviewboard.kde.org/r/100795/s/90/
> Cleanup dialog and hided close buttons
>   http://git.reviewboard.kde.org/r/100795/s/91/
> Tab bar context menu
>   http://git.reviewboard.kde.org/r/100795/s/92/
> 
> 
> Thanks,
> 
> Yannick
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110305/8d7d2324/attachment.html>