Review Request: Fix incomplete redrawing of a toolview

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100616/#review1754
-----------------------------------------------------------


I've played a bit with it, there is still a bug as you say and I think the solution proposed here is wrong

rather I think the layout should listen to changes in it (or get notified properly) that a dock widget changed, then check it's size limitations for correctness (newly shown dock widget has bigger min width then current width? => relayout)



- Milian


On Feb. 16, 2011, 9:31 p.m., Dmitry Risenberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100616/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2011, 9:31 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Fix a bug with incomplete redrawing of a toolview:
> 0. Assume "Documents" and "Projects" are both on the left.
> 1. Click on "Documents" tool.
> 2. Resize it to minimal width.
> 3. Click on the "Projects" tool and see a border not redrawn.
> 
> Reusing IdealMainLayout::resizeWidget didn't work, because this gets called on initialization when min/max constrains are computed wrong.
> 
> 
> Diffs
> -----
> 
>   sublime/ideal.cpp ad895619e18a16edc74372fa6135647173dbf35f 
>   sublime/ideallayout.h 308b4efbfbc74070ae482ed965ceb1040c02f236 
>   sublime/ideallayout.cpp f7b3d25dfa6be9195d5de2297b94fa902e1e35a2 
> 
> Diff: http://git.reviewboard.kde.org/r/100616/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110303/5d4950d0/attachment.html>