Review Request: Add options to StandardOutputView plugin

Milian Wolff mail at milianw.de
Thu Mar 3 20:07:14 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100666/#review1753
-----------------------------------------------------------


just tested it and added + fixed some things.

a major todo is bringing back the action collection usage as currently this patch removes the f4 / shift f4 navigation in build output views

- Milian


On March 2, 2011, 9:22 p.m., Silvère Lestang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100666/
> -----------------------------------------------------------
> 
> (Updated March 2, 2011, 9:22 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Add to StandardOutputView plugin:
>  * An option to display or not the two buttons "Select activated Item" and "Focus when selecting Item"
>  * An optional filter action, added to "build", "run" and "debug" outputview
>  * the possibility to add a list of QAction to an outputview (the actions appears in the toolbar and the context menu)
> 
> Fix: now when we remove an output view from one Area, it's removed from all Areas
> 
> Know bug: If you remove quickly many outputs displayed in more than one Area, KDevelop crash. I can't fix the bug as I don't know where and why it's appears exactly (if I attached the debugger, KDevelop is slower so making the bug disappear).
> 
> 
> Diffs
> -----
> 
>   plugins/standardoutputview/CMakeLists.txt bdb23e4 
>   plugins/standardoutputview/kdevstandardoutputview.rc 5455135 
>   plugins/standardoutputview/outputwidget.h eef3844 
>   plugins/standardoutputview/outputwidget.cpp 18e35e7 
>   plugins/standardoutputview/standardoutputview.h 4f7e1bf 
>   plugins/standardoutputview/standardoutputview.cpp fbdae75 
>   plugins/standardoutputview/tests/CMakeLists.txt PRE-CREATION 
>   plugins/standardoutputview/tests/standardoutputviewtest.h PRE-CREATION 
>   plugins/standardoutputview/tests/standardoutputviewtest.cpp PRE-CREATION 
>   plugins/standardoutputview/toolviewdata.h 14afd45 
> 
> Diff: http://git.reviewboard.kde.org/r/100666/diff
> 
> 
> Testing
> -------
> 
> A test has been adding for the plugin - it's pass - but it's reimplement the macro QTEST_KDEMAIN to get round a bug that I don't understand.
> 
> 
> Thanks,
> 
> Silvère
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110303/2f379b09/attachment.html>


More information about the KDevelop-devel mailing list