[kdevelop] languages/cpp/codecompletion: Revert "run generated 'create definition' and 'override' code through source formatter before insertion"

Milian Wolff mail at milianw.de
Thu Mar 3 09:10:23 UTC 2011


David nolden, 02.03.2011:
> Git commit d9c9dd6cc0980628f2b397f23d3dac6054daf181 by David nolden.
> Committed on 02/03/2011 at 21:10.
> Pushed by zwabel into branch 'master'.
> 
> Revert "run generated 'create definition' and 'override' code through
> source formatter before insertion"
> 
> This reverts commit 68cf85a72d5e1e877d7e98aa49376e382304ea41.
> 
> Reason: DocumentChangeSet cares about the formatting automatically, and it
> can do it better than this.


Hm but the changes where *not* formatted automatically so there must be a bug 
somewhere else, I'll investigate.

You can easily spot this by configuring your astyle formatter to use "align 
pointer at name" and try to implement a function taking a const&. It should 
be:

void foo::bar(const int &asdf)
{

}

instead of

void foo::bar(const int& asdf)
{

}

bye
-- 
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110303/b6e60a16/attachment.sig>


More information about the KDevelop-devel mailing list