Review Request: Custom defines support in QMake

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100732/#review1735
-----------------------------------------------------------

Ship it!


please attend to the two small changes below, then I'm fine with it. good work!


qmakemanager.h
<http://git.reviewboard.kde.org/r/100732/#comment1428>

    unrelated change



qmakemanager.cpp
<http://git.reviewboard.kde.org/r/100732/#comment1429>

    please use findQMakeFolderParent here


- Milian


On Feb. 24, 2011, 11:33 a.m., Julien Desgats wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100732/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2011, 11:33 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> This patch enables the parsing of DEFINES directive in QMake in order to make duchain aware of them.
> 
> 
> Diffs
> -----
> 
>   qmakemanager.h ede1e30 
>   qmakemanager.cpp e0e7042 
>   qmakeprojectfile.h d0fb1a9 
>   qmakeprojectfile.cpp 8f1b53d 
>   tests/test_qmakefile.h 2a3e272 
>   tests/test_qmakefile.cpp a974597 
> 
> Diff: http://git.reviewboard.kde.org/r/100732/diff
> 
> 
> Testing
> -------
> 
> A unit test has been added in tests/test_qmakefile.cpp
> 
> 
> Thanks,
> 
> Julien
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110302/c4ea0d36/attachment.html>