Review Request: Add options to StandardOutputView plugin

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100666/#review1734
-----------------------------------------------------------


some minor nit picks. But I really have to test that locally to sort out the crash in the tests you encountered...


plugins/standardoutputview/outputwidget.h
<http://git.reviewboard.kde.org/r/100666/#comment1422>

    should be const QString& filter



plugins/standardoutputview/outputwidget.cpp
<http://git.reviewboard.kde.org/r/100666/#comment1423>

    missing space before close )



plugins/standardoutputview/outputwidget.cpp
<http://git.reviewboard.kde.org/r/100666/#comment1424>

    missing whitespace before close )



plugins/standardoutputview/standardoutputview.h
<http://git.reviewboard.kde.org/r/100666/#comment1425>

    should be const QList<QActoin*>& actionList = ...



plugins/standardoutputview/standardoutputview.cpp
<http://git.reviewboard.kde.org/r/100666/#comment1426>

    so - does the standardOutputView provide *any* actions? if not, then the .rc file should be removed after all probably.
    
    but I understood your abstract in a way that suggests that the actions are configurable? so they still need to be setup somewhere?
    
    but commenting this out is wrong for sure... either remove it or add it back again



plugins/standardoutputview/standardoutputview.cpp
<http://git.reviewboard.kde.org/r/100666/#comment1427>

    missing const ref (see above)


- Milian


On Feb. 18, 2011, 1:27 p.m., Silvère Lestang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100666/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2011, 1:27 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Add to StandardOutputView plugin:
>  * An option to display or not the two buttons "Select activated Item" and "Focus when selecting Item"
>  * An optional filter action, added to "build", "run" and "debug" outputview
>  * the possibility to add a list of QAction to an outputview (the actions appears in the toolbar and the context menu)
> 
> Fix: now when we remove an output view from one Area, it's removed from all Areas
> 
> Know bug: If you remove quickly many outputs displayed in more than one Area, KDevelop crash. I can't fix the bug as I don't know where and why it's appears exactly (if I attached the debugger, KDevelop is slower so making the bug disappear).
> 
> 
> Diffs
> -----
> 
>   plugins/standardoutputview/CMakeLists.txt bdb23e4 
>   plugins/standardoutputview/kdevstandardoutputview.rc 5455135 
>   plugins/standardoutputview/outputwidget.h eef3844 
>   plugins/standardoutputview/outputwidget.cpp 18e35e7 
>   plugins/standardoutputview/standardoutputview.h 4f7e1bf 
>   plugins/standardoutputview/standardoutputview.cpp fbdae75 
>   plugins/standardoutputview/tests/CMakeLists.txt PRE-CREATION 
>   plugins/standardoutputview/tests/standardoutputviewtest.h PRE-CREATION 
>   plugins/standardoutputview/tests/standardoutputviewtest.cpp PRE-CREATION 
>   plugins/standardoutputview/toolviewdata.h 14afd45 
> 
> Diff: http://git.reviewboard.kde.org/r/100666/diff
> 
> 
> Testing
> -------
> 
> A test has been adding for the plugin - it's pass - but it's reimplement the macro QTEST_KDEMAIN to get round a bug that I don't understand.
> 
> 
> Thanks,
> 
> Silvère
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110302/d2344502/attachment.html>