Review Request: Fix MakeOutput items for cmake builds with relative paths

[Milian Wolff]

Manuel Massing, 01.03.2011:
> Hi Milian,
> 
> > yes, I'd prefer a single patch for that as it belongs together imo.
> 
> ok, will do when I'm at home.
> 
> > Furthermore the wrong i18n usage still persists in the patches you send.
> > Please fix that.
> 
> The i18n usage should be fixed in the patches I sent to you. It may have
> looked like I addressed your comments only after sending the patch, because
> I submited but forgot to publish the comments regarding your review.
> 
> > Also - correct me if I'm wrong - I fear your code is overly complex: Imo
> > the map with the iterators is not needed, the index lookup in a QList is
> 
> > O(1) and hence you should use that for currentDirs. See also:
> to avoid O(n^2) we want sub-linear key lookup - which is O(log N) with the
> map but O(n) with QList (i.e. despite the naming, indexOf is a
> key-lookup!)

a QList has no keys, hence it cannot be a key-lookup. And the Qt documentation 
is clear on this: Index lookup is O(1).
-- 
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110301/b673eb70/attachment.sig>