Review Request: Use monospace font on the documentation

[Aleix Pol Gonzalez]

> On June 26, 2011, 5:40 p.m., David Nolden wrote:
> > This patch also has another problem. All of the pretty HTML highlighting, for example from the Qt documentation, is suddenly gone in the navigation widget. Probably because of the new "span".
> 
> David Nolden wrote:
>     Actually, looking at the screenshots again, there is also no special formatting in the italic version, so the problem is more probably the qt-help support.
> 
> David Nolden wrote:
>     Update: There indeed _is_ highlighting lost.
>     
>     Normally, in the Qt documentation, monospace-fonts are used to highlight example-code as well as enumerator-names and similar. In the example screenshot here it probably doesn't work because the 'span' was already used.
> 
> Milian Wolff wrote:
>     hm actually yeah - I voted "ship it" because I was mainly thinking of non-provider-provided docs, i.e. stuff taken from the editor. There you want/need monospaced as otherwise ASCII-art and other layouting will be broken, which is somewhat common in apidox.
>     
>     for HTML stuff though, we should take what we get. If qthelp provides us without monospaced stuff, then indeed we should not change that...

Well, it took me quite some days to actually push it because I wasn't sure about it. I do see that people can't read it in italic so that is definitely bad anyway.

About what it's being said here, well, if we leave it like the provider says so, we'll get the same font everywhere and that's not good either, the eye has to be able to separe what's doc and what's duchain info. Maybe text size? A horizontal line?


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101514/#review4179
-----------------------------------------------------------


On June 6, 2011, 12:12 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101514/
> -----------------------------------------------------------
> 
> (Updated June 6, 2011, 12:12 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> here's how it looks like.
> 
> Who does prefer it?
> 
> 
> Diffs
> -----
> 
>   language/duchain/navigation/abstractnavigationcontext.h 9774640 
>   language/duchain/navigation/abstractnavigationcontext.cpp a067fcf 
> 
> Diff: http://git.reviewboard.kde.org/r/101514/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> how it looks like
>   http://git.reviewboard.kde.org/r/101514/s/175/
> new version
>   http://git.reviewboard.kde.org/r/101514/s/176/
> 
> 
> Thanks,
> 
> Aleix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110626/88a5202a/attachment.html>