Review Request: specializeFrom for functions and template identifier free specializations

[David Nolden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101690/#review4166
-----------------------------------------------------------

Ship it!


The stripPrefixes thing should be checked, because it is slow. Afterwards, ship it.


languages/cpp/cppduchain/declarationbuilder.cpp
<http://git.reviewboard.kde.org/r/101690/#comment3410>

    These two functions maybe should go into cppduchain.h/cpp



languages/cpp/cppduchain/declarationbuilder.cpp
<http://git.reviewboard.kde.org/r/101690/#comment3409>

    Do you deal with partial specializations here? Those have a non-empty template context.



languages/cpp/cppduchain/declarationbuilder.cpp
<http://git.reviewboard.kde.org/r/101690/#comment3412>

    Did you try without the stiprPrefixes? I doubt it is even required, because the same thing should be find with or without.



languages/cpp/cppduchain/declarationbuilder.cpp
<http://git.reviewboard.kde.org/r/101690/#comment3413>

    I think every member of a template-class is itself based on TemplateDeclaration too, so this TODO is obsolete.


- David


On June 22, 2011, 5:49 a.m., Olivier Jean de Gaalon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101690/
> -----------------------------------------------------------
> 
> (Updated June 22, 2011, 5:49 a.m.)
> 
> 
> Review request for KDevelop and David Nolden.
> 
> 
> Summary
> -------
> 
> Set specializedFrom for TemplateDeclarations in more cases then before.
> Make expressionvisitor check specializedFrom to find type of "this".
> 
> Also adds a test that should work (works in normal usage), but in the test environment for some reason the template declarations never have a templateContext().
> 
> 
> This addresses bug 183614.
>     http://bugs.kde.org/show_bug.cgi?id=183614
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cppduchain/declarationbuilder.h 2242da2 
>   languages/cpp/cppduchain/declarationbuilder.cpp 0423842 
>   languages/cpp/cppduchain/expressionvisitor.cpp eef33e3 
>   languages/cpp/cppduchain/tests/test_expressionparser.h 385568f 
>   languages/cpp/cppduchain/tests/test_expressionparser.cpp 22e123a 
> 
> Diff: http://git.reviewboard.kde.org/r/101690/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Olivier Jean de
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110626/0332fd7f/attachment.html>