Review Request: Still more QPointer replacements
Milian Wolff
mail at milianw.de
Sat Jun 25 10:06:58 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101588/#review4147
-----------------------------------------------------------
Ship it!
same as for the other review: commit if you can, otherwise send me the patch as created by "git format-patch"
many thanks
- Milian
On June 11, 2011, 10:25 p.m., Glen Kaukola wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101588/
> -----------------------------------------------------------
>
> (Updated June 11, 2011, 10:25 p.m.)
>
>
> Review request for KDevelop.
>
>
> Summary
> -------
>
> Replaced QPointer usage with QWeakPointer.
>
>
> This addresses bug 260586.
> http://bugs.kde.org/show_bug.cgi?id=260586
>
>
> Diffs
> -----
>
> shell/core.cpp 50d9351
> shell/core_p.h 0c2b05d
> shell/debugcontroller.h 316c56a
> shell/debugcontroller.cpp 662edba
> sublime/area.cpp d433e7a
> sublime/container.cpp feae38e
> sublime/ideal.h bf3c505
> sublime/ideal.cpp b66e881
> sublime/ideallayout.h 1b1ce7e
> sublime/mainwindow_p.h e80ae83
> sublime/mainwindow_p.cpp 65d6fe9
> vcs/vcspluginhelper.cpp e8463a7
>
> Diff: http://git.reviewboard.kde.org/r/101588/diff
>
>
> Testing
> -------
>
> Compiled and installed KDevPlatform and KDevelop. Ran KDevelop and verified some common tasks still worked.
>
>
> Thanks,
>
> Glen
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110625/58d298f5/attachment.html>
More information about the KDevelop-devel
mailing list