Review Request: Declaration::hasUses fix

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101722/#review4070
-----------------------------------------------------------

Ship it!


a unit test (in cpp?) would be good for this


language/duchain/declaration.cpp
<http://git.reviewboard.kde.org/r/101722/#comment3315>

    return early as soon as ret = true 



language/duchain/declaration.cpp
<http://git.reviewboard.kde.org/r/101722/#comment3316>

    same here, return early



language/duchain/declaration.cpp
<http://git.reviewboard.kde.org/r/101722/#comment3314>

    only ask for uses in other contexts when ret is not already true.
    
    or does the compiler do that automatically with the |= assignment operator?


- Milian


On June 22, 2011, 2:39 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101722/
> -----------------------------------------------------------
> 
> (Updated June 22, 2011, 2:39 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> In cases like the following didn't return false, even though 'a' is not being used:
> 
> int f()
> {
>   QByteArray a;
> }
> 
> One would expect it to be a fast equivalent of !Declaration::uses().isEmpty(), but the result wasn't the same.
> This change is also removing some calls in DUChain::uses()->hasUses (in case there's already a use in the local context) which I guess it's useful as well.
> 
> I'm putting this on review because I'm not sure the correct way to fix it is checking if it's <0.
> 
> 
> Diffs
> -----
> 
>   language/duchain/declaration.cpp b3a7700 
> 
> Diff: http://git.reviewboard.kde.org/r/101722/diff
> 
> 
> Testing
> -------
> 
> I've played with some code with some scripts from my thesis.
> 
> 
> Thanks,
> 
> Aleix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110622/65bf2f3e/attachment.html>