Review Request: specializeFrom for functions and template identifier free specializations
Olivier Jean de Gaalon
olivier.jg at gmail.com
Wed Jun 22 05:49:56 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101690/
-----------------------------------------------------------
(Updated June 22, 2011, 5:49 a.m.)
Review request for KDevelop and David Nolden.
Changes
-------
Check for specializations after the internal context for the class or function is assigned, allowing the declarations to be specializedFrom the first time around. (Thanks milian!)
Fixed isSpecialization to be (hopefully) correct.
Beefed up (now all working) tests.
Summary
-------
Set specializedFrom for TemplateDeclarations in more cases then before.
Make expressionvisitor check specializedFrom to find type of "this".
Also adds a test that should work (works in normal usage), but in the test environment for some reason the template declarations never have a templateContext().
This addresses bug 183614.
http://bugs.kde.org/show_bug.cgi?id=183614
Diffs (updated)
-----
languages/cpp/cppduchain/declarationbuilder.h 2242da2
languages/cpp/cppduchain/declarationbuilder.cpp 0423842
languages/cpp/cppduchain/expressionvisitor.cpp eef33e3
languages/cpp/cppduchain/tests/test_expressionparser.h 385568f
languages/cpp/cppduchain/tests/test_expressionparser.cpp 22e123a
Diff: http://git.reviewboard.kde.org/r/101690/diff
Testing
-------
Thanks,
Olivier Jean de
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110622/a2fc4b20/attachment.html>
More information about the KDevelop-devel
mailing list