Review Request: specializeFrom for functions and template identifier free specializations

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101690/#review4027
-----------------------------------------------------------


Clean code, good work. I got two general kdevplatform API questions which are somewhat unrelated though, see below. I would like to see some more research on the failing unit test though, before this is merged.

Thanks Oli :)


languages/cpp/cppduchain/declarationbuilder.cpp
<http://git.reviewboard.kde.org/r/101690/#comment3290>

    generally, unrelated: afair this is potentially slow just to check the availability of declarations, as it will read them from disk as well if required. A hasLocalDeclarations that only checks the DUContext indexed data would be much better here and potentially in other situations as well.
    
    David - what do you think?



languages/cpp/cppduchain/declarationbuilder.cpp
<http://git.reviewboard.kde.org/r/101690/#comment3291>

    has the QID no ctor taking a ID? If not, why? I'd assume this could also be optimized API-wise?



languages/cpp/cppduchain/tests/test_expressionparser.cpp
<http://git.reviewboard.kde.org/r/101690/#comment3292>

    when you print (->toString()) the specializedFrom - what does it say? Or is .data() = 0?


- Milian


On June 19, 2011, 7:51 a.m., Olivier Jean de Gaalon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101690/
> -----------------------------------------------------------
> 
> (Updated June 19, 2011, 7:51 a.m.)
> 
> 
> Review request for KDevelop and David Nolden.
> 
> 
> Summary
> -------
> 
> Set specializedFrom for TemplateDeclarations in more cases then before.
> Make expressionvisitor check specializedFrom to find type of "this".
> 
> Also adds a test that should work (works in normal usage), but in the test environment for some reason the template declarations never have a templateContext().
> 
> 
> This addresses bug 183614.
>     http://bugs.kde.org/show_bug.cgi?id=183614
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cppduchain/declarationbuilder.h 2242da2 
>   languages/cpp/cppduchain/declarationbuilder.cpp 0423842 
>   languages/cpp/cppduchain/expressionvisitor.cpp eef33e3 
>   languages/cpp/cppduchain/tests/test_expressionparser.h 385568f 
>   languages/cpp/cppduchain/tests/test_expressionparser.cpp 22e123a 
> 
> Diff: http://git.reviewboard.kde.org/r/101690/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Olivier Jean de
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110619/1c79be77/attachment.html>