Review Request: Global variables support

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101678/#review4025
-----------------------------------------------------------



duchain/declarationbuilder.cpp
<http://git.reviewboard.kde.org/r/101678/#comment3286>

    Please use findDeclarations() for this purpose instead of custom loops.



duchain/declarationbuilder.cpp
<http://git.reviewboard.kde.org/r/101678/#comment3287>

    A Declarations Range should describe the range where the object is declared. You set it to topContext()->range here, which contains the whole file. Why?



duchain/declarationbuilder.cpp
<http://git.reviewboard.kde.org/r/101678/#comment3289>

    You need to hold a write lock for this, it crashes for me.


Hi,

this crashes for me, so I couldn't test if it works. :)

- Sven


On June 18, 2011, 8:47 p.m., Miquel Canes Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101678/
> -----------------------------------------------------------
> 
> (Updated June 18, 2011, 8:47 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> This patch adds support for global variables.
> 
> I need some help with this problems:
> * The global variable is not hightlighted in the global line declaration. (global a)
> * Adding the global variable declaration line when this variable has been used, is not changing the scope of the local variable.
> 
> 
> Thank you!
> 
> 
> Diffs
> -----
> 
>   duchain/declarationbuilder.h ac337ca 
>   duchain/declarationbuilder.cpp 652ff23 
> 
> Diff: http://git.reviewboard.kde.org/r/101678/diff
> 
> 
> Testing
> -------
> 
> a = 2
> 
> def foo():
>   global a
>   a = 2
>   
> 
> 
> Thanks,
> 
> Miquel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110619/2234f71d/attachment.html>