Review Request: Fix tuple assignment

Sven Brauch svenbrauch at gmx.de
Sat Jun 18 17:45:29 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101675/#review4010
-----------------------------------------------------------


Hi,

This works well, thank you very much for your contribution. Could you please submit a patchfile which contains commit information, like this:
* Commit your changes to your local repository
* Call "git format-patch HEAD^" to generate a diff between the current state and the state before the most recent commit

That way, there will be proper author information in the commit (I can apply the patch and push it, and you're named as the author of the commit).

Or, in case you have push access, I'm fine with pushing this.

Cheers,
Sven

- Sven


On June 18, 2011, 5:15 p.m., Miquel Canes Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101675/
> -----------------------------------------------------------
> 
> (Updated June 18, 2011, 5:15 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> This change fix the tuple assignment
> 
> a = 2,3,4
> 
> a should be typed as tuple.
> 
> This assignment is already tested in the Types_data unit test.
> 
> 
> Diffs
> -----
> 
>   duchain/declarationbuilder.cpp 652ff23 
> 
> Diff: http://git.reviewboard.kde.org/r/101675/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Miquel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110618/928fd29b/attachment.html>


More information about the KDevelop-devel mailing list