Review Request: Use KStandardAction::fullScreen() in KDevelop::MainWindow.

[Parker Coates]

> On June 2, 2011, 4:32 p.m., Commit Hook wrote:
> > This review has been submitted with commit 1723a2805eca385ea5987960d426c1ca0e66f907 by Milian Wolff.

My wife had a baby a couple days after my original submission and somehow this *very* important patch fell off my radar. ;)

Sorry for abandoning it. Thanks for committing.


- Parker


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101009/#review3633
-----------------------------------------------------------


On April 1, 2011, 9:49 p.m., Parker Coates wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101009/
> -----------------------------------------------------------
> 
> (Updated April 1, 2011, 9:49 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Use KStandardAction::fullScreen() to "Full Screen Mode" action. This is less code AND makes KDevelop use the "standard" full screen shortcut, Ctrl+Shift+F. It is currently using Ctrl+Shift+F11.
> 
> As far as I can tell, there was no particular reason why the action was given a custom implementation. See http://commits.kde.org/kdevplatform/c7540f .
> 
> 
> Diffs
> -----
> 
>   shell/mainwindow_p.cpp c158b72 
> 
> Diff: http://git.reviewboard.kde.org/r/101009/diff
> 
> 
> Testing
> -------
> 
> Tested my KDevelop master installation. Everything seems to work as before.
> 
> 
> Thanks,
> 
> Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110603/fa1bfa8c/attachment.html>