Review Request: Fix cmake config for adding and removing build dirs using per-project cmake settings

[Andreas Pakulat]

> On July 26, 2011, 10:37 a.m., Milian Wolff wrote:
> > can you explain why the change from ProjectKCModule <-> KCModule is required?
> 
> Andreas Pakulat wrote:
>     That change is wrong. ProjectKCModule needs to be used for all kcm's that are showing project-specific configurations, otherwise things will horribly go wrong. So whatever the fix does, it does it wrong.

Somehow you got me hooked onto this bug Olivier so I looked into both the crash and the other problems with the kcm and fixed them all - except one. I've added a TODO about the remaining one (storing extra args, install prefix etc. per configured builddir persistently) since thats a bigger change.

Sorry if you now feel you've wasted your time on the patch, but maybe you still learned something new :)

PS: Also I'd like to add that my first answer was a bit harsh, sorry about that too.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102092/#review5115
-----------------------------------------------------------


On July 26, 2011, 2:22 a.m., Olivier Jean de Gaalon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102092/
> -----------------------------------------------------------
> 
> (Updated July 26, 2011, 2:22 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> As summary.
> 
> 
> This addresses bug 261519.
>     http://bugs.kde.org/show_bug.cgi?id=261519
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/CMakeLists.txt dbcf8ee 
>   projectmanagers/cmake/cmakeconfig.kcfg e48e2dd 
>   projectmanagers/cmake/cmakeconfig.kcfgc d580702 
>   projectmanagers/cmake/cmakeutils.h d5cce91 
>   projectmanagers/cmake/cmakeutils.cpp a0c2441 
>   projectmanagers/cmake/settings/cmakepreferences.h 4195948 
>   projectmanagers/cmake/settings/cmakepreferences.cpp 8a37842 
> 
> Diff: http://git.reviewboard.kde.org/r/102092/diff
> 
> 
> Testing
> -------
> 
> Adding and removing build dirs, bug 261519 reproduction instructions.
> 
> 
> Thanks,
> 
> Olivier Jean de
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110726/3922807d/attachment.html>