Review Request: Fix cmake config for adding and removing build dirs using per-project cmake settings
Milian Wolff
mail at milianw.de
Tue Jul 26 10:37:00 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102092/#review5115
-----------------------------------------------------------
can you explain why the change from ProjectKCModule <-> KCModule is required?
- Milian
On July 26, 2011, 2:22 a.m., Olivier Jean de Gaalon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102092/
> -----------------------------------------------------------
>
> (Updated July 26, 2011, 2:22 a.m.)
>
>
> Review request for KDevelop.
>
>
> Summary
> -------
>
> As summary.
>
>
> This addresses bug 261519.
> http://bugs.kde.org/show_bug.cgi?id=261519
>
>
> Diffs
> -----
>
> projectmanagers/cmake/CMakeLists.txt dbcf8ee
> projectmanagers/cmake/cmakeconfig.kcfg e48e2dd
> projectmanagers/cmake/cmakeconfig.kcfgc d580702
> projectmanagers/cmake/cmakeutils.h d5cce91
> projectmanagers/cmake/cmakeutils.cpp a0c2441
> projectmanagers/cmake/settings/cmakepreferences.h 4195948
> projectmanagers/cmake/settings/cmakepreferences.cpp 8a37842
>
> Diff: http://git.reviewboard.kde.org/r/102092/diff
>
>
> Testing
> -------
>
> Adding and removing build dirs, bug 261519 reproduction instructions.
>
>
> Thanks,
>
> Olivier Jean de
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110726/65064c70/attachment.html>
More information about the KDevelop-devel
mailing list