Review Request: Fix compilation after recent okteta API change

[Friedrich W. H. Kossebau]

> On July 13, 2011, 6:21 p.m., Friedrich W. H. Kossebau wrote:
> > Change should be okay, will end up using the same window as passed before IIRC :)
> > 
> > And sorry for not first bumping the ABI/API version of the Okteta/Kasten libs before doing the first change to the API, did not expect somebody to compile based on that in less than 24 hours :)
> > Will do the bump next, so the KDevelop buildsystem will no longer pick up the development version of these. Because there will be quite some API changes coming up the next weeks, so for Okteta/Kasten libs from SC 4.8 there rather will be needed a separate version of the plugin.
> > Expect me to take care of that :)
> 
> Christoph Feck wrote:
>     Stuff will be compiled as soon as it is committed :) But I don't really understand what you wrote... do you mean this review is actually useless because okteta will break API, and the kdevelop plugin has to be adjusted anyway? I could not test if it still compiles with r1241470 (that version of okteta fails to build, ld: cannot find -lkasten1core).
> 
> Friedrich W. H. Kossebau wrote:
>     Well, "useless" as in: not needed, yes. But will do no harm, the result will be the same, any window will be child to the active mainwindow, so no need to revert if commited already.
>     
>     Yes, for 4.8 the API/ABI of Okteta/Kasten libs will change/has already changed. Okteta/Kasten from SC 4.8 will need a separate version of the kdevelop plugin, indeed.
>     
>     For the failing build of Okteta, you might need to do a clean one, seems the buildsystem fails to cope with the changes I did on reusing the old build objects. Or was this with a clean rebuild? Then please send me the log, does not happen for me.

Christoph, shame on me, forgot to commit one file, so Okteta did not build for anyone (but me). Fixed now.


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101944/#review4703
-----------------------------------------------------------


On July 13, 2011, 12:44 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101944/
> -----------------------------------------------------------
> 
> (Updated July 13, 2011, 12:44 p.m.)
> 
> 
> Review request for KDevelop and Friedrich W. H. Kossebau.
> 
> 
> Summary
> -------
> 
> Since r1241388 kdevelop no longer compiles. This patch fixes compilation by simply removing the obsolete parameter. Not sure if it hurts to not pass it for older okteta versions (it defaults to 0 widget), or if there should be version checks and conditional code.
> 
> r1241388: [kdesdk/okteta] Changed: remove QWidget parameter from JobManager::executeJob(...)
> 
> 
> Diffs
> -----
> 
>   utils/okteta/oktetadocument.cpp 5ac0311 
> 
> Diff: http://git.reviewboard.kde.org/r/101944/diff
> 
> 
> Testing
> -------
> 
> Compiles with old and new okteta.
> 
> 
> Thanks,
> 
> Christoph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110714/13d152a2/attachment.html>