Review Request: Fix auto selection of the first tab when splitting views.

Milian Wolff mail at milianw.de
Wed Jul 13 17:49:03 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101938/#review4701
-----------------------------------------------------------

Ship it!


patch looks good, a unit test would be awesome as well!

bye

- Milian


On July 12, 2011, 11:09 p.m., Lambert CLARA wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101938/
> -----------------------------------------------------------
> 
> (Updated July 12, 2011, 11:09 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> With more than one file opened, and the displayed file not being the first tab,
> splitting view was automatically activating the first tab.
> 
> 
> This addresses bug 277643.
>     http://bugs.kde.org/show_bug.cgi?id=277643
> 
> 
> Diffs
> -----
> 
>   sublime/mainwindow_p.cpp ad18bd3 
> 
> Diff: http://git.reviewboard.kde.org/r/101938/diff
> 
> 
> Testing
> -------
> 
> Follow the steps described in the bug, do it again with multiple files opened at the same time and picking a random one to split.
> 
> 
> Thanks,
> 
> Lambert
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110713/066419c7/attachment.html>


More information about the KDevelop-devel mailing list